-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): add interactive env var #14994
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
I really think some of this may make sense in a GeneratorContext object, but I know @FrozenPandaz has been against that in the past. I imagine something like export interface GeneratorContext {
projectGraphSnapshot: ProjectGraph
dryRun: boolean
interactive: boolean
} |
FrozenPandaz
previously requested changes
Feb 14, 2023
42c87e3
to
cb3588c
Compare
cb3588c
to
7f33a67
Compare
7f33a67
to
83135a2
Compare
AgentEnder
requested changes
Feb 15, 2023
83135a2
to
3082fa9
Compare
AgentEnder
approved these changes
Feb 15, 2023
juristr
approved these changes
Feb 16, 2023
FrozenPandaz
pushed a commit
that referenced
this pull request
Feb 16, 2023
(cherry picked from commit 40deb00)
This was referenced Feb 26, 2023
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
NX_INTERACTIVE
env var that can be used from generators to determine if they can run interactive logic such as handling prompts.Move the setting of
NX_DRY_RUN
to the yargs handler of thegenerate
command so it is as visible as possible.