Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): add override to class component render() method #13743

Merged
merged 4 commits into from
Feb 16, 2023
Merged

fix(react): add override to class component render() method #13743

merged 4 commits into from
Feb 16, 2023

Conversation

Flusinerd
Copy link
Contributor

The override keyword is added to the render() method for class components

Closes #12769

Current Behavior

Currently the class component generator does not add the override keyword to the render() method.

Expected Behavior

The class component generator should add the override keyword to the render() method to prevent issues with noImplicitOverrides

Related Issue(s)

Fixes #12769

The override keyword is added to the render() method for class components

Closes #12769
@vercel
Copy link

vercel bot commented Dec 9, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
nx-dev ⬜️ Ignored (Inspect) Visit Preview Feb 12, 2023 at 2:45PM (UTC)

The override keyword is added to the render() method for class components

Closes #12769
@Flusinerd
Copy link
Contributor Author

Maybe someone can help me. I ran nx format and everything has been commited. Yet the ci tells me its a format error

@FrozenPandaz FrozenPandaz assigned jaysoo and ndcunningham and unassigned jaysoo Dec 14, 2022
Copy link
Contributor

@ndcunningham ndcunningham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

github-actions bot commented Mar 3, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants