From 98c83cc8b5f55ae9f4d775df32388260bea2fd3a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Leosvel=20P=C3=A9rez=20Espinosa?= Date: Thu, 23 May 2024 17:25:09 +0200 Subject: [PATCH] cleanup(angular): address pr feedback --- docs/generated/packages/angular/generators/setup-ssr.json | 5 +++-- .../executors/utilities/ng-packagr/stylesheet-processor.ts | 3 +-- packages/angular/src/generators/setup-ssr/schema.json | 5 +++-- 3 files changed, 7 insertions(+), 6 deletions(-) diff --git a/docs/generated/packages/angular/generators/setup-ssr.json b/docs/generated/packages/angular/generators/setup-ssr.json index 2d2013f2b160e..a10318cebd78a 100644 --- a/docs/generated/packages/angular/generators/setup-ssr.json +++ b/docs/generated/packages/angular/generators/setup-ssr.json @@ -19,8 +19,9 @@ "appId": { "type": "string", "format": "html-selector", - "description": "The `appId` to use with `withServerTransition`. _Note: This is deprecated and ignored since Angular 16 and not supported since Angular 17._", - "default": "serverApp" + "description": "The `appId` to use with `withServerTransition`.", + "default": "serverApp", + "x-deprecated": "This is deprecated and ignored since Angular 16 and not supported since Angular 17." }, "main": { "type": "string", diff --git a/packages/angular/src/executors/utilities/ng-packagr/stylesheet-processor.ts b/packages/angular/src/executors/utilities/ng-packagr/stylesheet-processor.ts index c72e27ff8e671..d59605b7ca442 100644 --- a/packages/angular/src/executors/utilities/ng-packagr/stylesheet-processor.ts +++ b/packages/angular/src/executors/utilities/ng-packagr/stylesheet-processor.ts @@ -95,8 +95,7 @@ export class StylesheetProcessor { getInstalledPackageVersionInfo('ng-packagr'); let tailwindConfigPath: string | undefined; let postcssConfiguration: PostcssConfiguration | undefined; - // TODO(leo): change to a stable version when it's released - if (gte(ngPackagrVersion, '18.0.0-next.3')) { + if (gte(ngPackagrVersion, '18.0.0')) { const { findTailwindConfiguration, generateSearchDirectories, diff --git a/packages/angular/src/generators/setup-ssr/schema.json b/packages/angular/src/generators/setup-ssr/schema.json index be85a23aefef6..0f6e875fb213c 100644 --- a/packages/angular/src/generators/setup-ssr/schema.json +++ b/packages/angular/src/generators/setup-ssr/schema.json @@ -19,8 +19,9 @@ "appId": { "type": "string", "format": "html-selector", - "description": "The `appId` to use with `withServerTransition`. _Note: This is deprecated and ignored since Angular 16 and not supported since Angular 17._", - "default": "serverApp" + "description": "The `appId` to use with `withServerTransition`.", + "default": "serverApp", + "x-deprecated": "This is deprecated and ignored since Angular 16 and not supported since Angular 17." }, "main": { "type": "string",