From 82a7685c9f3723beb963d40ca07ca723367a126a Mon Sep 17 00:00:00 2001 From: "Jan-Niklas W." <6104311+niklas-wortmann@users.noreply.github.com> Date: Wed, 24 Jul 2024 07:54:37 -0400 Subject: [PATCH] feat(core): update pnpm/action-setup to v4 in ci-workflow generator (#26838) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit I just created a new nx monorepo with pnpm and in the github.ci file it uses pnpm/action-setup@v2. I ran into the following issue https://github.com/pnpm/action-setup/issues/136 and updating to pnpm/action-setup@v4 solved the issue for me --------- Co-authored-by: Jan-Niklas Wortmann Co-authored-by: Miroslav Jonaš (cherry picked from commit 9faeddc1d6fa9e92e17da50aed5d5aba15055833) --- .../ci-workflow/__snapshots__/ci-workflow.spec.ts.snap | 8 ++++---- .../.github/workflows/__workflowFileName__.yml__tmpl__ | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/packages/workspace/src/generators/ci-workflow/__snapshots__/ci-workflow.spec.ts.snap b/packages/workspace/src/generators/ci-workflow/__snapshots__/ci-workflow.spec.ts.snap index b593b3e21ede9..d83db996ae5eb 100644 --- a/packages/workspace/src/generators/ci-workflow/__snapshots__/ci-workflow.spec.ts.snap +++ b/packages/workspace/src/generators/ci-workflow/__snapshots__/ci-workflow.spec.ts.snap @@ -918,7 +918,7 @@ jobs: with: fetch-depth: 0 - - uses: pnpm/action-setup@v2 + - uses: pnpm/action-setup@v4 with: version: 8 @@ -964,7 +964,7 @@ jobs: with: fetch-depth: 0 - - uses: pnpm/action-setup@v2 + - uses: pnpm/action-setup@v4 with: version: 8 @@ -2214,7 +2214,7 @@ jobs: with: fetch-depth: 0 - - uses: pnpm/action-setup@v2 + - uses: pnpm/action-setup@v4 with: version: 8 @@ -2261,7 +2261,7 @@ jobs: with: fetch-depth: 0 - - uses: pnpm/action-setup@v2 + - uses: pnpm/action-setup@v4 with: version: 8 diff --git a/packages/workspace/src/generators/ci-workflow/files/github/.github/workflows/__workflowFileName__.yml__tmpl__ b/packages/workspace/src/generators/ci-workflow/files/github/.github/workflows/__workflowFileName__.yml__tmpl__ index 14a73ba60d3a3..664f02d6180c7 100644 --- a/packages/workspace/src/generators/ci-workflow/files/github/.github/workflows/__workflowFileName__.yml__tmpl__ +++ b/packages/workspace/src/generators/ci-workflow/files/github/.github/workflows/__workflowFileName__.yml__tmpl__ @@ -18,7 +18,7 @@ jobs: with: fetch-depth: 0 <% if(packageManager == 'pnpm'){ %> - - uses: pnpm/action-setup@v2 + - uses: pnpm/action-setup@v4 with: version: 8 <% } %>