missing disarm timeout monitor after connection refused #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @bixuehujin, the bug is indeed there but a more proper fix would consist in not invoking Do you prefer to rebase your pull request or create a new one with this change, or should I just commit the proper fix myself? |
|
Thinks, just commit your proper fix. |
nrk
added a commit
that referenced
this pull request
Sep 2, 2013
Invoking "disconnect()" two times in a row triggers a new connection attempt on the second call but this will end up in a connection loop. We should also fix "disconnect()" to make it so that it doesn't try to fetch a new socket resource when the connection is not actually active, but we'll leave this to a different commit. Thanks to @bixuehujin for reporting the issue (see #8).
|
Alright fixed, thanks! |
nrk
added a commit
that referenced
this pull request
Sep 4, 2013
This change prevents the underlying connection from creating and opening a new socket when StreamConnection::disconnect() is invoked on a closed connection. Partially related to #8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue will cause the 'Connection timed out' error will also be raised even though a 'Connection refused' error raised before.