This repository has been archived by the owner on Dec 3, 2021. It is now read-only.
Adding image build support to the preview system #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mierdin
force-pushed
the
image-build-support
branch
26 times, most recently
from
b42b185 to
8f6813e
Compare
Mierdin
force-pushed
the
image-build-support
branch
4 times, most recently
from
e2bea45 to
b0063b3
Compare
Mierdin
force-pushed
the
image-build-support
branch
21 times, most recently
from
efa2e75 to
f4a408e
Compare
Signed-off-by: Matt Oswalt <[email protected]>
Mierdin
force-pushed
the
image-build-support
branch
from
f4a408e to
7406a5b
Compare
|
I've constructed a preview of your change, and it is available at https://preview-v95ldel.nrelabs.io/ This is a fully-deployed version of the full NRE Labs site, so navigate to the lesson catalog to find your lesson. Please note that this preview is only active for 12 hours Details
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a long time, the NRE Labs contribution process has had a big technical hurdle to cross, which was that all changes to images must be contributed first before any content contribution changes that might rely on these changes. This was because images were not automatically built as part of the CI process, and therefore must be contributed first, deployed to
latest, and then the preview system could use them in a future PR.This PR is the culmination of some work that has gone on in the back-end to support the building of images for previews in real-time, so this hurdle no longer exists. The majority of the work is behind the scenes, but this PR does introduce the necessary logic to the CI workflow to trigger this activity and wait to deploy a preview once all of the images are built properly.
Currently the NRE labs docs still reference this limitation but I'll be updating that in the near future.