This repository has been archived by the owner on Dec 3, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 79
Misc Curriculum Updates for Antidote 0.7 #341
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matt Oswalt <[email protected]>
Signed-off-by: Matt Oswalt <[email protected]>
Signed-off-by: Matt Oswalt <[email protected]>
Signed-off-by: Matt Oswalt <[email protected]>
Signed-off-by: Matt Oswalt <[email protected]>
…omicity) Signed-off-by: Matt Oswalt <[email protected]>
Signed-off-by: Matt Oswalt <[email protected]>
Signed-off-by: Matt Oswalt <[email protected]>
Signed-off-by: Matt Oswalt <[email protected]>
Signed-off-by: Matt Oswalt <[email protected]>
Signed-off-by: Matt Oswalt <[email protected]>
Signed-off-by: Matt Oswalt <[email protected]>
Signed-off-by: Matt Oswalt <[email protected]>
Signed-off-by: Matt Oswalt <[email protected]>
Signed-off-by: Matt Oswalt <[email protected]>
Signed-off-by: Matt Oswalt <[email protected]>
Signed-off-by: Matt Oswalt <[email protected]>
Signed-off-by: Matt Oswalt <[email protected]>
Signed-off-by: Matt Oswalt <[email protected]>
Mierdin
force-pushed
the
misc-curriculum-fixes
branch
from
July 25, 2020 04:15
db53598
to
d2ae1e2
Compare
Signed-off-by: Matt Oswalt <[email protected]>
Signed-off-by: Matt Oswalt <[email protected]>
Signed-off-by: Matt Oswalt <[email protected]>
Signed-off-by: Matt Oswalt <[email protected]>
Signed-off-by: Matt Oswalt <[email protected]>
Signed-off-by: Matt Oswalt <[email protected]>
Signed-off-by: Matt Oswalt <[email protected]>
Signed-off-by: Matt Oswalt <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will take care of a lot of miscellaneous updates that are needed for the upcoming Antidote 0.7.0 update.
Any heavy lifting, such as entire lesson re-vamps, or moving a certain lesson to a new network platform like cRPD, will take place in a dedicated PR. This PR is more about the various small things that need to be done even to lessons that would otherwise not need to be touched.
Updating vQFX Configs
The main thing that triggered this PR was the change to the way the configurator script works for NAPALM configurations in nre-learning/antidote-images#5. Since that code is a lot simpler, and doesn't by default do any templating, there are a lot of vQFX configurations that need to be changed. I elected to ensure that all relevant sections of each vqfx configuration are using the
merge
orreplace
method as needed, and simply removed the em0 section that had this template before. In retrospect this is how it should always have been done. That's why there are so many vqfx config updates in this PR.Testing
Since this was a curriculum-wide update, I took the opportunity to test each and every existing lesson to ensure that it worked on the current platform. Going through this list was the main drive behind a lot of the commits in this PR.
Minimal Updates Planned
Converted to cRPD
Didn't convert (only two vqfxs)
Scaled Down for now (maybe want to scale back up when using cRPD)