This repository has been archived by the owner on Dec 3, 2021. It is now read-only.
Add cRPD Image and image flavor params #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matt Oswalt <[email protected]>
Signed-off-by: Matt Oswalt <[email protected]>
Signed-off-by: Matt Oswalt <[email protected]>
Signed-off-by: Matt Oswalt <[email protected]>
Signed-off-by: Matt Oswalt <[email protected]>
Signed-off-by: Matt Oswalt <[email protected]>
Signed-off-by: Matt Oswalt <[email protected]>
|
I've constructed a preview of your change, and it is available at https://preview-gw4xq2h.nrelabs.io/ This is a fully-deployed version of the full NRE Labs site, so navigate to the lesson catalog to find your lesson. Please note that this preview is only active for 12 hours Details
|
Mierdin
changed the title
Signed-off-by: Matt Oswalt <[email protected]>
Mierdin
changed the title
Signed-off-by: Matt Oswalt <[email protected]>
Signed-off-by: Matt Oswalt <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the images in the curriculum with the new "flavor" parameter, which gives greater control over the runtime for the images.
I'm also taking this opportunity to update the JSNAPy lesson to use cRPD instead of the vQFX image. Currently, our new cRPD image doesn't come with a license so we'll use OSPF instead of BGP. Before the next release, I'll be opening another PR to update the JSNAPy content to match this, and give it a top-to-bottom re-vamp, but I wanted to start actually using the cRPD image somewhere so we could track how its doing.