Adding Cumulus Image and Proof of Concept Lesson #253
Conversation
|
Is this ready to go from your perspective? I should have time later in the week to check this out and merge but if you have more changes I'll wait to take a look. |
I forked/created a branch in Syringe and updated "config.go" to include a cvx with a specific version number: "antidotelabs/cvx-3.7.6" . It should be good to go now, all of it. It's PTR only, obviously. |
Mierdin
changed the title
There was a problem hiding this comment.
Thanks for this - getting another network OS in here is a big win. Some comments below, most relatively minor.
The big thing was that I couldn't get the image to build, since there's no step to download the base image from the GCP bucket. We'll need this so the release workflow can auto-build the image without any manual steps. See what I did in in the Makefile for container-vqfx - obviously we're not using that image yet but a similar script for downloading those assets should prove useful here.
Also, looks like you need to pull the latest master from upstream; the CHANGELOG was updated in the latest release so there's a merge conflict that should be an easy fix.
…ge from gcp bucket.
|
Removed unnecessary directory. Removed references to "3.7.6" in all files. Added "gsutil cp" command to Makefile to download cvx image from gcp bucket. |
Add Cumulus image and demo topology to curriculum. PTR only. Uses the python configuration option (specified in the lesson.meta.yaml file) to copy configuration files to the booted images, then restarts associated processes.