Skip to content
This repository has been archived by the owner on Dec 3, 2021. It is now read-only.

New Lesson - Robot Framework #125

Merged
merged 9 commits into from
Nov 9, 2018
Merged

New Lesson - Robot Framework #125

merged 9 commits into from
Nov 9, 2018

Conversation

lara29
Copy link
Contributor

@lara29 lara29 commented Nov 1, 2018

@Mierdin @cloudtoad Please review the changes.

cc @saimkhan92

Copy link
Member

@Mierdin Mierdin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a really great lesson! I love that each of the stages are fairly short, packing a lot of information into a short space, meaning the reader can get up to speed on robot without knowing a lot, very quickly. This is in keeping with the spirit of existing lessons.

My main feedback at the moment is around basic housekeeping stuff. See my comments inline as well as below:

There are a lot of commits in this PR with really nondescriptive names. If these are merged as-is, it would clutter up the history with a lot of changes that make it hard to track what's being changed where. I can squash this for you but I'd rather you do it so you get credit for the commit(s). Please use git reset <commit id> --soft to backtrack to one of the earliest commits and then re-commit the changes using more descriptive commit messages. Quality over quantity here. Then, you can force-push your amended branch, and the changes will show up in this PR.

Please remove the following files from the branch:

  • lessons/lesson-29/output.xml
  • lessons/lesson-29/log.html
  • lessons/lesson-29/report.html
  • lessons/lesson-29/pycache/substring.cpython-37.pyc
  • lessons/lesson-29/pycache/JunosDevice.cpython-37.pyc

Please also delete:

  • lessons/lesson-29/stage1/lessondiagram.png
  • lessons/lesson-29/stage2/lessondiagram.png
    and instead place one at the lesson root. Also update the syringe.yaml file accordingly.

images/utility/push.sh Outdated Show resolved Hide resolved
lessons/lesson-29/report.html Outdated Show resolved Hide resolved
lessons/lesson-29/output.xml Outdated Show resolved Hide resolved
lessons/lesson-29/log.html Outdated Show resolved Hide resolved
lessons/lesson-29/stage1/guide.md Show resolved Hide resolved
lessons/lesson-29/stage2/guide.md Outdated Show resolved Hide resolved
lessons/lesson-29/stage1/guide.md Show resolved Hide resolved
@Mierdin
Copy link
Member

Mierdin commented Nov 5, 2018

Also, note that CI is failing because no CHANGELOG update. Please update the changelog as indicated in other sections.

@Mierdin Mierdin changed the title Review request for Robot Framework tutorial New Lesson - Robot Framework Nov 6, 2018
@lara29
Copy link
Contributor Author

lara29 commented Nov 6, 2018

Thanks for the review @Mierdin. We will update the lesson as per your comments.

@saimkhan92 saimkhan92 force-pushed the master branch 4 times, most recently from f935a1d to c2e9adc Compare November 6, 2018 22:24
@saimkhan92
Copy link
Contributor

Also, note that CI is failing because no CHANGELOG update. Please update the changelog as indicated in other sections.

CHANGELOG updated

@saimkhan92
Copy link
Contributor

All the commits have been squashed.
All CI checks passing.

@lara29
Copy link
Contributor Author

lara29 commented Nov 6, 2018

@Mierdin We have made all the requested changes. Please review and let us know if we need to make any other modifications. Thanks!
cc @saimkhan92

Copy link
Member

@Mierdin Mierdin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good work!

@Mierdin Mierdin merged commit 5fb47c5 into nre-learning:master Nov 9, 2018
@lara29
Copy link
Contributor Author

lara29 commented Nov 9, 2018

Thanks @Mierdin

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants