-
Notifications
You must be signed in to change notification settings - Fork 79
New Lesson - Using Jinja for Config Templates #121
Conversation
0ea24eb
to
cbe95af
Compare
e899777
to
68bded5
Compare
@Mierdin Can you please review our lesson. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great start! I have a few comments, most of which are suggestions you can simply accept if you wish. Most of my other comments are structural or syntactic - for instance you're using italics instead of a code snippet. Generally my concerns are about consistency - if you're using a certain style in the beginning, such as the way you're referring to code snippets or examples, do that consistently across the lesson. I didn't get all the way through the PR - I stopped at lesson 3 because I didn't want to drown you with a billion comments on the same thing. Could you go back and try to apply those comments across the lesson as a whole? I think it will end up looking a lot better on the front-end.
Also - have you tested this out locally? The reason I ask is that the utility container doesn't currently have jinja installed. I am hoping you've instead tested this with your own image. In any case, the users will want to have access to jinja, so please add this to images/utility/requirements.txt
in this PR.
Thanks to you both for your hard work on this - ping me here or on Slack for any questions.
f110a91
to
980b19a
Compare
@Mierdin we have made the proposed changes in stage 1 and 2 and we also reviewed the stage 3 and stage 4. Could you please check it now? |
c43bc56
to
fce48ef
Compare
@Mierdin I have changed the syntax snippet to three-backticks (```) to and have renumbered the snippet accordingly. Issue:
|
@Mierdin We have added a new stage in the lesson based on Jeremy's recommendation. Hence, moved parts around in other lessons. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really good. Thanks for working on this - I imagine this will rapidly become one of the most popular lessons - I often blow network engineers' minds with what can be done with Jinja.
Co-Authored-By: ShrutiVPawaskar <[email protected]>
Introduction to Jinja2 and Junos PyEz
Part 1 – Intro to Jinja2
Discusses Jijna2 syntax
Part 2 – Into to PyEz
Part 3 –Configuring Junos Device using PyEz and Jinja2 Template
Part 4 - Optimizing Configuration Push
with Config(dev, mode='private') as cu:
cu.load(template=template, template_vars=template_vars, format='text')
Part 5 –Configuring multiple Junos devices using Jinja2 template
Closes nre-learning/antidote#72