Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use release please manifest configuration #164

Merged
merged 1 commit into from
Aug 25, 2022

Conversation

lukekarrys
Copy link
Contributor

No description provided.

@lukekarrys lukekarrys requested a review from a team as a code owner August 24, 2022 21:32
@lukekarrys lukekarrys force-pushed the lk/release-please-manifest branch from 8b7c547 to 80c5fc3 Compare August 24, 2022 21:42
Copy link
Member

@wraithgar wraithgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose that there is work to be done in each repo as we update to this version of template-oss?

@lukekarrys lukekarrys force-pushed the lk/release-please-manifest branch from 80c5fc3 to c970315 Compare August 25, 2022 20:35
@lukekarrys lukekarrys force-pushed the lk/release-please-manifest branch from c970315 to 18e0d3d Compare August 25, 2022 20:37
@lukekarrys
Copy link
Contributor Author

I suppose that there is work to be done in each repo as we update to this version of template-oss?

It should Just Work ™️. template-oss will bootstrap the necessary manifest file with the current version. The only concern would be if a repo got updated to this while the versions in package.json were not accurate (meaning it had been bumped but not released). In that case we'd have to manually bootstrap release please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants