Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Epic: refactor npm commands #402

Closed
Tracked by #536
wraithgar opened this issue Oct 19, 2021 · 4 comments
Closed
Tracked by #536

Epic: refactor npm commands #402

wraithgar opened this issue Oct 19, 2021 · 4 comments
Assignees

Comments

@wraithgar
Copy link
Member

wraithgar commented Oct 19, 2021

We want to refactor the commands to end up in a place where we can do per-command options and subcommands.

  • First refactor will be to move commands into isolated subfolder, clean up module api for each command, and make test pass again (this is the biggest granular change, ideally after this the changes can be smaller and won't require test refactoring)
  • Second refactor will be to pull aliases into the subcommands themselves (refactor(commands): move alias info into commands #305)
  • After this we can architect and plan subcommands, and per-command config
@lukekarrys
Copy link
Contributor

Does this include or take the place of #305?

@wraithgar
Copy link
Member Author

Thanks @lukekarrys, I just kind of infodumped into this to get started, that's a subtask, updated the issue body to reflect that.

@darcyclarke darcyclarke changed the title refactor npm commands Epic: refactor npm commands Nov 2, 2021
@darcyclarke darcyclarke mentioned this issue Mar 23, 2022
32 tasks
@darcyclarke darcyclarke mentioned this issue Aug 22, 2022
46 tasks
@lukekarrys
Copy link
Contributor

This is complete @wraithgar 😄

@wraithgar
Copy link
Member Author

#305 is still the next step but this isn't an active epic so it's ok to be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants