You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If we move the npm.config.get('workspace') out of lib/npm.js and let the execWorkspaces functions do that themselves it will be more clear inside the exec functions what's going on, and likely lead to more optimizations down the road inside each command (i.e. set a "use workspaces" flag and reuse all the rest of the code or something).
This should wait till the velocity on adding workspace-aware commands has slowed down. This is cleanup for afterwards.
Alternatively we could move the getWorkspaces util function up into lib/npm.js itself, so that what execWorkspaces gets passed is already standardized off of what's in there.
The text was updated successfully, but these errors were encountered:
If we move the
npm.config.get('workspace')
out oflib/npm.js
and let theexecWorkspaces
functions do that themselves it will be more clear inside the exec functions what's going on, and likely lead to more optimizations down the road inside each command (i.e. set a "use workspaces" flag and reuse all the rest of the code or something).This should wait till the velocity on adding workspace-aware commands has slowed down. This is cleanup for afterwards.
Alternatively we could move the
getWorkspaces
util function up into lib/npm.js itself, so that whatexecWorkspaces
gets passed is already standardized off of what's in there.The text was updated successfully, but these errors were encountered: