fix: correctly translate paths when using bash in windows #96
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes the issue when using bash as the script-shell in windows, the problem was that we were passing a windows path to bash as a script to run. to correct it, we translate
C:
to/c
and replace all backslashes with forward slashes. as an example,C:\\Directory\\filename
becomes/C/Directory/filename
correcting this problem brought to light a few things that make the module simpler:
-c
flag when using bashchmod +x
the script fileno changes were made to the cmd.exe behavior
closes #90