Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix accessibility] severity 4 Issues #1352

Merged
merged 2 commits into from
Nov 6, 2024
Merged

[Fix accessibility] severity 4 Issues #1352

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc07cc9
Refactor site-title component to remove unnecessary role attribute
jpg619 Oct 31, 2024
007b952
Refactor DefaultLayout component to remove TableOfContents.Desktop fr…
jpg619 Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/site-title.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import Link from './link'
import useSiteMetadata from '../hooks/use-site-metadata'

const NpmLogo = ({size, sx}) => (
<Box sx={{...sx, color: 'logoBg'}} role="banner">
<Box sx={{...sx, color: 'logoBg'}}>
<svg height={size} width={size} viewBox="0 0 700 700" fill="currentColor" aria-hidden="true">
<polygon fill="currentColor" points="0,700 700,700 700,0 0,0" />
<polygon fill="#ffffff" points="150,550 350,550 350,250 450,250 450,550 550,550 550,150 150,150 " />
Expand Down
3 changes: 1 addition & 2 deletions src/layout.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,15 +39,13 @@ const DefaultLayout = ({children}) => {
<Box
sx={{
justifyContent: 'center',
flexDirection: 'row-reverse',
display: 'flex',
maxWidth: '1200px',
mx: 'auto',
width: '100%',
p: [4, 5, 6, 7],
}}
>
<TableOfContents.Desktop />
<Container as="main">
<Box sx={{mb: 4}}>
<Breadcrumbs />
Expand All @@ -60,6 +58,7 @@ const DefaultLayout = ({children}) => {
{children}
<PageFooter />
</Container>
<TableOfContents.Desktop />
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keyboard focus order from left to right

</Box>
)
}
Expand Down