Even more deps updates #7498
Merged
Even more deps updates #7498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lukekarrys
commented
May 9, 2024
lukekarrys
commented
- deps: [email protected]
- deps: @npmcli/[email protected]
- deps: @sigstore/[email protected]
- deps: [email protected]
- deps: @sigstore/[email protected]
lukekarrys
force-pushed
the
lk/even-more-deps
branch
from
262e927
to
2151d29
Compare
wraithgar
reviewed
May 10, 2024
wraithgar
reviewed
May 10, 2024
| @@ -4,7 +4,7 @@ | |||
| "description": "Manage node_modules trees", | |||
| "dependencies": { | |||
| "@isaacs/string-locale-compare": "^1.1.0", | |||
| "@npmcli/fs": "^3.1.0", | |||
| "@npmcli/fs": "^3.1.1", | |||
There was a problem hiding this comment.
Can we not do this in workspaces?
|
We already are bumping all the workspaces in this release so we don't have to revert the package.json changes here. In the future we should stop doing that, they're packages not bundles. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.