Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: @npmcli/[email protected] #4116

Merged
merged 1 commit into from
Dec 8, 2021
Merged

deps: @npmcli/[email protected] #4116

merged 1 commit into from
Dec 8, 2021

Conversation

nlf
Copy link
Contributor

@nlf nlf commented Dec 2, 2021

This version bump implements overrides support

References

@nlf nlf requested a review from a team as a code owner December 2, 2021 22:46
@nlf nlf mentioned this pull request Dec 2, 2021
Merged
@darcyclarke darcyclarke added Release 8.x work is associated with a specific npm 8 release semver:minor new backwards-compatible feature labels Dec 5, 2021
@nlf @wraithgar
deps: @npmcli/[email protected]
4b0c29a 
PR-URL: #4116
Credit: @nlf
Close: #4116
Reviewed-by: @wraithgar
@wraithgar wraithgar merged commit 4b0c29a into release-next Dec 8, 2021
@wraithgar wraithgar deleted the nlf/deps-arborist-4.1.0 branch December 8, 2021 21:30
@npm-robot
Copy link
Contributor

found 4 benchmarks with statistically significant performance improvements

  • app-large: modules-only, no-lock
  • app-medium: modules-only, no-lock
timing results
app-large clean lock-only cache-only cache-only
peer-deps		 modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@7 59.702 ±5.69 33.182 ±0.35 19.843 ±0.16 21.994 ±0.45 28.849 ±1.15 20.344 ±5.97 2.640 ±0.09 13.253 ±0.31 2.646 ±0.00 3.668 ±0.07
#4116 67.235 ±3.41 33.848 ±0.16 20.300 ±0.09 22.888 ±0.81 3.393 ±0.16 3.256 ±0.02 2.671 ±0.08 14.039 ±0.08 2.698 ±0.04 3.629 ±0.03
app-medium clean lock-only cache-only cache-only
peer-deps		 modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@7 41.268 ±1.36 25.435 ±0.15 14.847 ±0.06 15.550 ±0.02 21.009 ±2.13 8.258 ±0.24 2.663 ±0.06 9.908 ±0.04 2.575 ±0.07 3.168 ±0.06
#4116 42.489 ±1.42 26.650 ±0.12 15.390 ±0.06 16.664 ±0.35 3.046 ±0.11 3.196 ±0.03 2.811 ±0.07 10.128 ±0.32 2.584 ±0.02 3.205 ±0.02

@nlf nlf mentioned this pull request Dec 9, 2021
Merged
@npm-robot npm-robot mentioned this pull request Dec 9, 2021
Closed
@acid-chicken acid-chicken mentioned this pull request Apr 7, 2022
Closed
@p2edwards p2edwards mentioned this pull request Oct 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wraithgar wraithgar wraithgar approved these changes

Assignees
No one assigned
Labels
Release 8.x work is associated with a specific npm 8 release semver:minor new backwards-compatible feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nlf @npm-robot @wraithgar @darcyclarke