-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] should not install optional peer dependencies #2615
Comments
How long would a potential fix take? Angular is an important framework. |
@jcesarmobile can you try the latest |
It's still not working. |
@jcesarmobile can you try updating to the latest v7 (ie. |
I confirm it works, thanks! |
Current Behavior:
@angular-devkit/build-angular has a peerDependenty to ng-packagr, but it’s marked as optional
https://github.com/angular/angular-cli/blob/master/packages/angular_devkit/build_angular/package.json#L105
and ng-packagr has a peerDependency to tsickle, but also marked as optional
https://github.com/ng-packagr/ng-packagr/blob/master/package.json#L64
and tsickle has a peerDependency to typescript 3, while the other two require typescript 4 and fail to install because of the typescript version mismatch
related
angular/tsickle#1242
Expected Behavior:
npm should not install optional peer dependencies.
Steps To Reproduce:
npm install typescript
npm install npm install [email protected] --save-exact
you need to use that exact version because the optional dependency was removed in following versions
Environment:
The text was updated successfully, but these errors were encountered: