Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Print registry config value before on npm login #2071

Closed
ruyadorno opened this issue Oct 28, 2020 · 2 comments
Closed

[Feature] Print registry config value before on npm login #2071

ruyadorno opened this issue Oct 28, 2020 · 2 comments
Labels
Enhancement new feature or improvement Good First Issue good issue or PR for newcomers Release 7.x work is associated with a specific npm 7 release

Comments

@ruyadorno
Copy link
Contributor

Problem:

It is opaque which service will receive credentials for "npm login". This can lead to leaked credentials.

Logging into a non-standard registry is a 2-command process. Not only that, but one can be logged into multiple registries for various scopes. Give a multitude of registries, when I perform "npm login", depending on the flags, my credentials can be sent to a number of services. It would be nice to know exactly which one before credentials are entered.

Solution:

Currently:

$ npm config set registry https://npm.fury.io/USERNAME/
$ npm login
Username: <user>
Password: <pass>
Email: (this IS public) <email>
Logged in as <user> on https://npm.fury.io/USERNAME/.

Proposed:

$ npm config set registry https://npm.fury.io/USERNAME/
$ npm login
Log in on https://npm.fury.io/USERNAME/
Username: <user>
Password: <pass>
Email: (this IS public) <email>
Logged in as <user> on https://npm.fury.io/USERNAME/.
@ruyadorno ruyadorno added Enhancement new feature or improvement Good First Issue good issue or PR for newcomers Release 7.x work is associated with a specific npm 7 release labels Oct 28, 2020
@shuang2411
Copy link

To whom it may concern, would that be ok to assign this issue to me?

@ruyadorno
Copy link
Contributor Author

Thanks for the interest @shuang2411 but we already have a PR for it over at #2075 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement new feature or improvement Good First Issue good issue or PR for newcomers Release 7.x work is associated with a specific npm 7 release
Projects
None yet
3 participants