-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update to latest release #1451
base: workers
Are you sure you want to change the base?
update to latest release #1451
Conversation
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
catch (result) | ||
{ | ||
if (typeof result !== 'undefined' && step.outputAs) | ||
results[job.name][step.outputAs] = result |
Check warning
Code scanning / CodeQL
Prototype-polluting assignment Medium
library input
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix AI about 1 month ago
To fix the prototype pollution issue, we should ensure that the keys used in the results
object cannot be __proto__
, constructor
, or prototype
. This can be achieved by either using a Map
object or by explicitly checking and rejecting these keys.
The best way to fix this without changing existing functionality is to add a check to reject these keys. This approach is straightforward and does not require significant changes to the existing code structure.
-
Copy modified lines R310-R312
@@ -309,2 +309,5 @@ | ||
let previousStepName: string = name + '#prerequisites'; | ||
if (job.name === '__proto__' || job.name === 'constructor' || job.name === 'prototype') { | ||
throw new Error('Invalid job name: ' + job.name); | ||
} | ||
results[job.name] = {}; |
BREAKING CHANGE: moved to mixins for vertical and horizontal
mimicking Material UI
Quality Gate passedIssues Measures |
No description provided.