-
-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Intent to drop .NET Core App 2.1 as target framework #566
Comments
Our 2.1 applications have some dependencies on some Microsoft provides a |
I'm trying to add helper to drastically simplify paging with |
@clement911 Have you looked at Microsoft.Bcl.AsyncInterfaces it adds the support for |
I'm not too sure. Between the TFMs and the lang version it gets pretty confusing. |
That is part of C#8 so you would need to use the core 3.0 SDK to build the code. You can still target a lower framework Found an example here: |
Looks like this package requires .NETFramework 4.6.1 minimum but ShopifySharp still targets .NET45. |
@ChaoticIke while it might be possible to implement right now with a combination of |
FYI, I ended writing a helper function in my own code.
|
@clement911 My plan is to drop the framework support in 6.0 -- not clear on when that release will come/be needed. .NET Core can be dropped at any point since it's not a breaking change for anyone, I might even do it in the next release. |
@nozzlegear why can't the library simply target |
|
Related to #438, I intend to drop
netcoreapp2.1
as a target framework. Note that the package still supports netstandard 1.4, which is the reason I'm going to drop the core app as a target. Somebody can correct me if I'm wrong here, but there's no need to targetnetcoreappX
when we're already targetingnetstandard
, as thenetstandard
package will continue working in a .NET Core app without any changes. I think I was just a little confused about the new .NET versioning/framework naming scheme when it was added as a target.The text was updated successfully, but these errors were encountered: