Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to publish VPC Flow Logs to either S3 or CW #151

Merged
merged 5 commits into from
Nov 22, 2020
Merged

Add option to publish VPC Flow Logs to either S3 or CW #151

merged 5 commits into from
Nov 22, 2020

Conversation

jmcorallo
Copy link
Contributor

Address #144

  • vpc_log_destination_type defaults to CW to avoid breaking existing deployments
  • if S3 is used, bucket creation is outside the scope of this module
  • also addresses issue where IAM Role was created even if VPC flow logs were not enabled

@jmcorallo jmcorallo mentioned this pull request Nov 21, 2020
Closed
nozaq
nozaq requested changes Nov 22, 2020
View reviewed changes
Copy link
Owner

@nozaq nozaq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I've made one request, but otherwise it LGTM.

modules/vpc-baseline/variables.tf Show resolved Hide resolved
@nozaq nozaq merged commit c1d81fa into nozaq:master Nov 22, 2020
@nozaq
Copy link
Owner

nozaq commented Nov 22, 2020

@jmcorallo Just merged, thank you for your contribution!

@nozaq nozaq added the enhancement New feature or request label Nov 22, 2020
@jmcorallo jmcorallo deleted the issue144-vpc-flowlogs-to-s3 branch November 22, 2020 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nozaq nozaq nozaq requested changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmcorallo @nozaq