Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notifications stay open after click #118

Open
noyainrain opened this issue Sep 17, 2020 · 0 comments
Open

Notifications stay open after click #118

noyainrain opened this issue Sep 17, 2020 · 0 comments
Labels
bug good-first-issue

Comments

@noyainrain
Copy link
Owner

noyainrain commented Sep 17, 2020 •
edited
Loading

Notifications don't close after click in Chrome for Android. Most browsers automatically close notifications, but Chrome's behavior is actually correct. To reproduce:

  1. Open Hello
  2. Execute ui.enableDeviceNotifications()
  3. Click the notification
  4. Observe that the notification stays open

I think we can close() the notification on notificationclick in service.js.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good-first-issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@noyainrain