-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to webcomponents.js 2 #71
Labels
Comments
Experimental branch: https://github.com/noyainrain/meetling/tree/web-components-v1 |
To be clear this isn't a refactor it's a bonafied feature change @noyainrain |
Dear @snuggs, I'm not sure I get your point, could you please elaborate? :) |
Moved to noyainrain/micro#54. |
noyainrain
changed the title
Upgrade to web components v1
Upgrade to webcomponents.js 2
Feb 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Upgrade to web components v1 once the webcomponents polyfill supports customized builtin elements, which some of our elements are.
Some things changed and we need to refactor:
document.registerElement -> customElements.define
createdCallback -> constructor
(note https://html.spec.whatwg.org/multipage/custom-elements.html#custom-element-conformance)attachedCallback -> connectedCallback
detachedCallback -> disconnectedCallback
With this, reconsider Shadow DOM, using the more lightweight Shady DOM polyifill.
The text was updated successfully, but these errors were encountered: