Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to webcomponents.js 2 #71

Closed
noyainrain opened this issue Jun 17, 2017 · 5 comments
Closed

Upgrade to webcomponents.js 2 #71

noyainrain opened this issue Jun 17, 2017 · 5 comments
Labels

Comments

@noyainrain
Copy link
Owner

noyainrain commented Jun 17, 2017

Upgrade to web components v1 once the webcomponents polyfill supports customized builtin elements, which some of our elements are.

Some things changed and we need to refactor:

With this, reconsider Shadow DOM, using the more lightweight Shady DOM polyifill.

@noyainrain
Copy link
Owner Author

@snuggs
Copy link

snuggs commented Jul 21, 2017

To be clear this isn't a refactor it's a bonafied feature change @noyainrain

@noyainrain
Copy link
Owner Author

Dear @snuggs, I'm not sure I get your point, could you please elaborate? :)

@snuggs
Copy link

snuggs commented Jul 28, 2017

Oh bcause of the different API. There were breaking changes to v1 API which is what makes it a "non-refactor".
capture d ecran 2017-07-28 a 12 16 56

@noyainrain
Copy link
Owner Author

Moved to noyainrain/micro#54.

@noyainrain noyainrain changed the title Upgrade to web components v1 Upgrade to webcomponents.js 2 Feb 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants