Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prepublish hooks] [v1.2.0] npm i failed caused by breaking changes of commander #1584

Closed
mulongjiangliu opened this issue Sep 28, 2021 · 1 comment
Labels
Milestone

Comments

@mulongjiangliu
Copy link

Describe the bug
It throws error after npm i for v1.2.0.

Error logs:
image

To Reproduce
Steps to reproduce the behavior:

  1. Get source code of 1.2.0 version;
  2. run npm i.
  3. See error

Expected behavior
npm i runs successfully.

Environment

image

Server (please complete the following information):

  • noVNC version: 1.2.0

Additional context
As I researched, the commander version specified in pacakge.json is *, so it get latest version 8.2.0.
While there is a breaking change in commander version 7.0.0, it nolonger supports access option directly on program. So all paramters passed to makeLibFiles function are undefined.

image

As a workround, I specified the commander version to ^8.0.0, and modified the code in use_requre.js as below:

image

image

@CendioOssman
Copy link
Member

Thanks for letting us know. Fixed in a85c85f.

@CendioOssman CendioOssman added this to the v1.3.0 milestone Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants