You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
It throws error after npm i for v1.2.0.
Error logs:
To Reproduce
Steps to reproduce the behavior:
Get source code of 1.2.0 version;
run npm i.
See error
Expected behavior npm i runs successfully.
Environment
Server (please complete the following information):
noVNC version: 1.2.0
Additional context
As I researched, the commander version specified in pacakge.json is *, so it get latest version 8.2.0.
While there is a breaking change in commander version 7.0.0, it nolonger supports access option directly on program. So all paramters passed to makeLibFiles function are undefined.
As a workround, I specified the commander version to ^8.0.0, and modified the code in use_requre.js as below:
The text was updated successfully, but these errors were encountered:
Describe the bug
It throws error after
npm i
for v1.2.0.Error logs:
To Reproduce
Steps to reproduce the behavior:
npm i
.Expected behavior
npm i
runs successfully.Environment
Server (please complete the following information):
Additional context
As I researched, the
commander
version specified inpacakge.json
is*
, so it get latest version 8.2.0.While there is a breaking change in commander version 7.0.0, it nolonger supports access option directly on
program
. So all paramters passed tomakeLibFiles
function areundefined
.As a workround, I specified the
commander
version to^8.0.0
, and modified the code inuse_requre.js
as below:The text was updated successfully, but these errors were encountered: