Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libpng: Cannot build with Xcode generator #466

Open
capnkenny opened this issue Jun 23, 2022 · 3 comments
Open

libpng: Cannot build with Xcode generator #466

capnkenny opened this issue Jun 23, 2022 · 3 comments
Labels
bug Something isn't working engine core Tickets pertaining to the engine core codebase. mac Tickets specifically related to MacOS. wontfix This will not be worked on

Comments

@capnkenny
Copy link
Member

pnggroup/libpng#344

Until the patch that was PRed for libpng is in, the new build system for Xcode refuses to build libpng and fails.
Workaround: Only use ninja or Unix Makefiles generators for now.

Fwiw, there's mention that this issue actually appears on all generators now, but Xcode is the only one that flat-out rejects it.

@capnkenny capnkenny added bug Something isn't working wontfix This will not be worked on engine core Tickets pertaining to the engine core codebase. mac Tickets specifically related to MacOS. labels Jun 23, 2022
@capnkenny
Copy link
Member Author

The alternative is to host a fork of libpng with the fix cherry picked - this would unblock Xcode generation from failing on libpng. However, zlib would also need evaluation as its CMakeLists.txt file is very similar.

@capnkenny
Copy link
Member Author

Another alternative is that we pull in libpng similar how to this project is doing it: https://github.com/diasurgical/devilutionX/blob/master/3rdParty/libpng/CMakeLists.txt

This appears to build libpng with the ported fix (proposed by the same user) which should unblock this.
@RubyNova - any thoughts or concerns here?

@RubyNova
Copy link
Member

If there's a proposed fix that we can reliably target then use that.

Aside from that its up to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working engine core Tickets pertaining to the engine core codebase. mac Tickets specifically related to MacOS. wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants