Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignored config #444

Closed
road2react opened this issue Sep 3, 2022 · 1 comment
Closed

Ignored config #444

road2react opened this issue Sep 3, 2022 · 1 comment

Comments

@road2react
Copy link

road2react commented Sep 3, 2022

After a recent v5 pre-release, RecommendedWatcher::new requires a config parameter. However, right now it's being ignored:

fn new<F: EventHandler>(event_handler: F, _config: Config) -> Result<Self> {

Is this intentional?

@0xpr03
Copy link
Member

0xpr03 commented Sep 3, 2022

Yes, whether it makes sense depends on the watcher. PollWatcher is currently the only for which the config holds relevant values, and it can also be the recommended one, depending on your system. The interface allows settings values in case your recommended watcher should end up being one of the affected ones. And some values cannot be changed after watcher creation, such as compare_contents. It's also relevant for allowing such customization when using the debouncer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants