Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme: List View Search Results #144

Closed
3 tasks
jillpe opened this issue Oct 2, 2024 · 1 comment
Closed
3 tasks

Theme: List View Search Results #144

jillpe opened this issue Oct 2, 2024 · 1 comment

Comments

@jillpe
Copy link

jillpe commented Oct 2, 2024

Summary

There are some discrepancies between the Search Results List View in Knapsack versus HykuCommons:

  • Items do not have properly styled metadata
    • Collections' counts are incorrectly positioned
    • metadata is positioned too close in proximity to thumbnail

Knapsack

Screen.Recording.2024-10-08.at.12.10.06.PM.mov

HykuCommons

Screen.Recording.2024-10-08.at.12.09.27.PM.mov

Acceptance Criteria

  • Items and their metadata fit in the container list view container
    • Collections counts are positioned like HykuCommons
    • Metadata is positioned like HykuCommons
@jillpe jillpe converted this from a draft issue Oct 2, 2024
@jillpe jillpe changed the title List View Search Results Page Theme Theme: List View Search Results Oct 8, 2024
@laritakr
Copy link
Contributor

laritakr commented Dec 2, 2024

Closing ticket as layout has changed after updates. Any remaining issues should be handled by #173

@laritakr laritakr closed this as not planned Won't fix, can't repro, duplicate, stale Dec 2, 2024
@github-project-automation github-project-automation bot moved this from Ready for Development to Done in PalsKnapsack Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

2 participants