Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎁 update abilities file to be AF + Valk #82

Closed
1 task
Tracked by #35
ShanaLMoore opened this issue Jan 3, 2024 · 3 comments
Closed
1 task
Tracked by #35

🎁 update abilities file to be AF + Valk #82

ShanaLMoore opened this issue Jan 3, 2024 · 3 comments

Comments

@ShanaLMoore
Copy link

ShanaLMoore commented Jan 3, 2024

Summary

Add resource models to the ability file.

ref

Acceptance Criteria

  • The resource models should be included in consideration of abilities

Screenshots or Video

Testing Instructions

TBD

Notes

https://docs.google.com/document/d/1WCB-5qIDCGhMQSuAzM70MDIuP4EQJhtnvgZt2x8MS4o/edit
https://drive.google.com/file/d/1oSLVhSF34JUgJBni9kN7FhPuOao5XSfz/view?usp=sharing

@ShanaLMoore ShanaLMoore changed the title update abilities file to be AF + Valk 🎁 update abilities file to be AF + Valk Jan 3, 2024
@ShanaLMoore ShanaLMoore self-assigned this Jan 5, 2024
@ShanaLMoore
Copy link
Author

ShanaLMoore commented Jan 5, 2024

I am not seeing where we'd need to add models to the ability.rb file.

@ShanaLMoore
Copy link
Author

ability.rb includes work_roles which already references Hyrax.config.curation+concerns so I don't think we need to add anything to it.

image

@ShanaLMoore
Copy link
Author

ShanaLMoore commented Jan 8, 2024

Re opening. Even though the ability is true for the curation concerns, #admin_set_with_desposit? fails so #can_create_any_work? does too. ref: https://github.com/samvera/hyrax/blob/f0af79238ed008b6e6696fc0c71a39389b5c9dd8/app/models/concerns/hyrax/ability.rb#L106-L110

Extra context:

This behavior was seen on a fresh build with no data/no admin sets and one couldn't be created at the tiem

@ShanaLMoore ShanaLMoore removed their assignment Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant