Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong content streamed from CD in certain situations (save states included) #122

Closed
gingerbeardman opened this issue Mar 2, 2019 · 6 comments

Comments

@gingerbeardman
Copy link

gingerbeardman commented Mar 2, 2019

This has been bugging me and I'm happy to have finally found the cause. Sorry to say that it appears to be limited to PCSX ReARMed. Beetle PSX does not have this problem.

Problem

CD access is out of whack, resulting in incorrect audio/video playing in certain circumstances.

Game

Jun Classic C.C. & Rope Club
http://redump.org/disc/29981/

I'm using redump verified CUE & BINs as I'm a dumper of this game. Merging to a single BIN, ISO, CHD, PBP does not help.

Background

This is a golf game with lots of audio tracks (music, description of each hole, digitised sound effects of wind, water, rain, birds). There are also short thumbnail FMV clips that play when you hit a good shot.

Save States

These were made using RetroArch 1.7.6 PCSX-ReARMed r22 v0370856.
I get the same problem on Nintendo Switch, which is where I noticed it.

How to Reproduce

  1. Load chosen core (Beetle/PCSX)
  2. Load game content
  3. Load save state (0/1)

Expected Results

  • ball comes to rest, yardage displays
  • short FMV clip in lower right corner "nice shot!"
    (Beetle PSX does this)

Actual Results

  • ball comes to rest, yardage displays
  • two CD Audio tracks, both short phrases, followed by the thumbnail FMV clip that is cut short
    (PCSX does this)

Screenshot

This is the final facial expression of the person in the FMV; this is never seen using PCSX.

screen shot 2019-03-02 at 22 30 45

Analysis

It seems to me that PCSX seeks CD tracks at incorrect locations, somehow?

So the drive seeks to a point before the FMV and ends up in a CD Audio track, playback begins and goes through two Audio tracks not stopping at either of their end points, and then finally playback gets to the start of the FMV and it proceeds to play, but by now the "playback duration" is almost exhausted and so the FMV is cut short.

The amount of error seems to increase with the number of CD tracks.

There are many other situations with this game where the wrong audio/video plays.

Let me know if I can be of further assistance with this one.

@gameblabla
Copy link
Contributor

gameblabla commented Mar 3, 2019

You might be onto something !
PCSX-Rearmed is based on PCSX-Reloaded so i thought i would check the other forks to see if they exhibit the same issues.
I tried PCSX-Reloaded (https://github.com/gameblabla/pcsxr) and PCSXR NXGP (https://github.com/iCatButler/pcsxr) and they also suffer from the same issue. (at least for CTR)

So i would suggest you try your golf game on PCSXR and see if it exhibits the same issue. (it probably will)

Sadly, looks like there's no known fix for it yet.

@gingerbeardman
Copy link
Author

gingerbeardman commented Mar 3, 2019

You are indeed correct, it seems to be a longstanding bug.

It happens with PCSX-Reloaded 1.9.95 (SVNREVISION) on macOS.
After the ball lands, I get two voice clips and the beginning of the thumbnail FMV.

Here is a freeze/save state: SLPM86080-000.pcsxrstate.zip

@gameblabla
Copy link
Contributor

As i noticed in my CTR issue, after i took my 2 patches that came from the PCSX Redux project,
it fixed the desync issues i had in CTR !

I believe this could also fix this one.
See
#118 (comment)

@gingerbeardman
Copy link
Author

Thanks, I'll have to wait for it to be merged

@gameblabla
Copy link
Contributor

gameblabla commented Aug 16, 2021

@gingerbeardman Libretro merged my PR so at least as of now, libretro's fork has my fix
libretro#536

Another tester told me it fixed the freeze issue in FF8 after Lunar Cry FMV.
Sadly for notaz's version, it will take a while.

EDIT: Notaz merged it, give it a try.

@notaz
Copy link
Owner

notaz commented Sep 29, 2023

Assuming this is fixed, reopen if not.

@notaz notaz closed this as completed Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants