Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarification on annotation for io.cncf.notary.x509chain.thumbprint#S256 #250

Closed
plooploops opened this issue Apr 10, 2023 · 5 comments
Closed
Labels

Comments

@plooploops
Copy link

plooploops commented Apr 10, 2023

Per the storage section of the signature specification, the annotation io.cncf.notary.x509chain.thumbprint#S256 is "A REQUIRED annotation whose value contains the list of SHA-256 fingerprint of signing certificate and certificate chain (including root) used for signature generation."

I wanted to understand if the annotation io.cncf.notary.x509chain.thumbprint#S256 is still required, as I have been able to attach an artifact without this annotation and then later verify using notation v1.0.0-rc.2.

  • In this scenario, the annotation appears to be optional which aligns with this earlier signature spec which includes the following for the annotation: "This OPTIONAL property contains arbitrary metadata for the image manifest."
  • Also, it would be helpful to understand if the annotation io.cncf.notary.x509chain.thumbprint#S256 is required (e.g. as of a certain released notation version), or if it's required for the future
@yizha1
Copy link
Contributor

yizha1 commented Apr 11, 2023

@plooploops This annotation is required per Notary signature spec. It is not enforced in the implementation yet.

@gokarnm, @priteshbandi and @shizhMSFT do you have any comments?

@yizha1
Copy link
Contributor

yizha1 commented Apr 11, 2023

Similar to this issue notaryproject/notation#475, there is a need for users to push/attach notary compliant signature to container images.

@shizhMSFT
Copy link
Contributor

It is required for the future. Basically, it will be used for signature filtering.

Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the Stale label Sep 13, 2024
Copy link

This issue was closed because it has been stalled for 30 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants