Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Plug-in spec to support multiple signature formats #146

Closed
SteveLasker opened this issue Mar 30, 2022 · 3 comments
Closed

Update Plug-in spec to support multiple signature formats #146

SteveLasker opened this issue Mar 30, 2022 · 3 comments
Milestone

Comments

@SteveLasker
Copy link
Contributor

To support multiple signature formats (#145) the plug-in spec will need updates to support multiple signature/envelope formats. Specifically, JWT and COSE.

A desired outcome is the plug-in spec would specify a named parameter for what signature format is requested, and the plug-in APIs wouldn't need changing.

@SteveLasker SteveLasker added this to the RC-1 milestone Mar 30, 2022
@sajayantony
Copy link
Contributor

/cc @gokarnm

@gokarnm
Copy link
Contributor

gokarnm commented Mar 30, 2022

The spec already supports multiple envelope format using signatureEnvelopeType, in the Signature Envelope Generator interface. Let me know if any other changes are required.

{
  "contract-version" : <major-version.minor-version>,
  
  // Complete key definition from /notation/config.JSON /signingKeys/keys with matching key name
  "keyDefinition" : <key definition>, 

  "payload" : <Base64 encoded payload to be signed>,
  
  // The type of payload - currently a descriptor
  "payloadType" : "application/vnd.oci.descriptor.v1+json",
  
  // The expected response signature envelope
  "signatureEnvelopeType" : "application/vnd.cncf.notary.v2.jws.v1"
}

@SteveLasker
Copy link
Contributor Author

@shizhMSFT, can you confirm your question is answered and adding code doesn't change the plug-in spec?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants