Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass debug flag to plugin #904

Open
priteshbandi opened this issue Mar 6, 2024 · 2 comments
Open

pass debug flag to plugin #904

priteshbandi opened this issue Mar 6, 2024 · 2 comments
Labels
enhancement New feature or request
Milestone

Comments

@priteshbandi
Copy link
Contributor

Is your feature request related to a problem?

Currently, Notation prints debug information using the --debug flag, but there's no mechanism to pass this flag to plugins. Additionally, since Notation doesn't transmit any environment variables to plugins, plugin producers have limited options to output debug information.

What solution do you propose?

Set the environment variable ENABLE_NOTATION_PLUGIN_Debug=1 when invoking the plugin, or call the plugin with the --debug flag.

What alternatives have you considered?

Passing the debug flag as plugin configuration poses a challenge as the plugin needs to parse the input to determine if debugging is enabled or not. In come cases plugin producer might be trying to debug parsing issues.

Any additional context?

No response

@priteshbandi priteshbandi added enhancement New feature or request triage Need to triage labels Mar 6, 2024
@yizha1 yizha1 removed the triage Need to triage label Mar 12, 2024
@yizha1 yizha1 added this to the 1.3.0 milestone Mar 12, 2024
@yizha1
Copy link
Contributor

yizha1 commented Mar 12, 2024

Per the discussion in the meeting on Mar 12 2024, set the milestone for 1.3.0.

@JeyJeyGao
Copy link
Contributor

@priteshbandi Do you have any idea how the plugin outputs the debug information? Currently, the response from the plugin is in JSON format and follows the plugin's standards. However, there is no field for debug information.

@yizha1 yizha1 modified the milestones: 1.3.0, Future Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Todo
Development

No branches or pull requests

3 participants