Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix of setHttpDebugLog function #851

Closed
Two-Hearts opened this issue Dec 19, 2023 · 0 comments · Fixed by #857
Closed

Fix of setHttpDebugLog function #851

Two-Hearts opened this issue Dec 19, 2023 · 0 comments · Fixed by #857
Assignees
Labels
bug Something isn't working
Milestone

Comments

@Two-Hearts
Copy link
Contributor

What is not working as expected?

Creating an issue to track these comments:
#827 (comment)
#827 (comment)

What did you expect to happen?

Quote from @shizhMSFT: When authClient.Client is nil, http.DefaultClient.Transport is changed to http.DefaultTransport if it is nil. Later, http.DefaultClient.Transport is changed to NewTransport. That's a global change and should be avoided.

How can we reproduce it?

nil

Describe your environment

all environments

What is the version of your Notation CLI or Notation Library?

current main branch

@Two-Hearts Two-Hearts added bug Something isn't working triage Need to triage labels Dec 19, 2023
@yizha1 yizha1 removed the triage Need to triage label Dec 26, 2023
@yizha1 yizha1 added this to the 1.1.0 milestone Dec 26, 2023
@yizha1 yizha1 moved this from Todo to In Progress in Notary Project Planning Board Jan 2, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Notary Project Planning Board Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants