Dead code cleanup and other quality improvements

[priteshbandi]

• Cleanup dead code cleanup in notation-core-go refactoring.
• verification/helpers.go#L85: support more types of URI like "domain.com/repository", "domain.com/repository:tag"
• verification/verifier.go#L165: verify the plugin's version is equal to or greater than outcome.SignerInfo.SignedAttributes.VerificationPluginMinVersion
• verification/helpers.go#L147: multi-valued RDNs are not supported; TODO: add spec reference here

[iamsamirzon]

@yizha1 , @FeynmanZhou - The first two items ( dead code clean up and more UTs) should get done as part of refactoring the code for Notation-go and Notation CLI. We believe no changes are required in the notation-core-go repo

The third item, "TODOs", Pritesh will identify the must have TODOs for RC-1

cc: @vaninrao10 , @shizhMSFT , @dtzar

[priteshbandi]

Moved, it to main issue

TODOs identified for RC1,

Should be covered as part of refactor:

• notation/cmd/notation/list.go

  Line 67 in f0e77eb

  // TODO: this is a temporary function and will be replaced after

• notation/internal/ioutil/print.go

  Line 62 in 193a533

  // TODO[https://github.com/notaryproject/notation/issues/304]: print out failed validations as warnings.

• notation/internal/ioutil/print.go

  Line 76 in 193a533

  // TODO[https://github.com/notaryproject/notation/issues/304]: print out detailed errors in debug mode.

• notation/internal/envelope/envelope.go

  Line 20 in 8d1d4dc

  // TODO: abandon this fature in RC1.

Needs some extra work:

• verification/helpers.go#L85: support more types of URI like "domain.com/repository", "domain.com/repository:tag"
• verification/verifier.go#L165: verify the plugin's version is equal to or greater than outcome.SignerInfo.SignedAttributes.VerificationPluginMinVersion
• verification/helpers.go#L147: multi-valued RDNs are not supported; TODO: add spec reference here

[yizha1]

updated milestone to rc.2 per discussion

[yizha1]

Close as no activities for more than 6 months. Please open new issues in the respective repo if needed.