Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] notation login #119

Closed
4 tasks
SteveLasker opened this issue Oct 27, 2021 · 10 comments · Fixed by #218 or #256
Closed
4 tasks

[Feature] notation login #119

SteveLasker opened this issue Oct 27, 2021 · 10 comments · Fixed by #218 or #256
Assignees
Labels
enhancement New feature or request epic new work which requires one or more features, tasks, or issues to complete.
Milestone

Comments

@SteveLasker
Copy link
Contributor

The current notation cli supports -u / -p for each command. However, having to provide the username/password for each command is tedious at best.
Alternatively, cli commands provide a notation login -u -p type of experience where the subsequent commands can forgo having to provide the commands each time.

Ideally, this would be provided by the oras-go library, and notation just benefits from that common experience.

  • auth should support encrypted storage or usernames and passwords, possibly following the docker encryption story
  • not be dependent on the docker client or libraries being installed
  • support basic auth flows that use cloud provider tokens for native authentication
  • support 2fa cloud provider capabilities
@SteveLasker SteveLasker added the enhancement New feature or request label Oct 27, 2021
@SteveLasker SteveLasker added this to the alpha-2 milestone Oct 27, 2021
@shizhMSFT
Copy link
Contributor

Current notation CLI has only a very basic auth / credential module. This will eventually be resolved by moving to the oras-go library.

@SteveLasker SteveLasker modified the milestones: alpha.2, rc.1 Apr 21, 2022
@SteveLasker
Copy link
Contributor Author

@shizhMSFT will you be able to integrate this into RC1?
Instead of having to set NOTATION_USERNAME and NOTATION_PASSWORD, we can pickup the docker cred store.

@shizhMSFT
Copy link
Contributor

Login functionalities are currently not present in oras-go. Let me estimate if it fits the RC1 plan.

@gokarnm
Copy link
Contributor

gokarnm commented May 19, 2022

@shizhMSFT were you able to look into #170, basic auth with notation sign $IMAGE -u <USERNAME> -p <PASSWORD> seems to be broken, will doing a new release with ORAS integration changes fix this issue?

@shizhMSFT
Copy link
Contributor

Yes, a new release of notation should fix it.

@gokarnm
Copy link
Contributor

gokarnm commented May 20, 2022

Just clarifying, a new release of notation alpha, without any code changes should fix this issue? Some ORAS integration work was done in Jan (#150).

@shizhMSFT
Copy link
Contributor

@binbin-li Could you ack this item as you are working on this?

@binbin-li
Copy link
Contributor

acked

@shizhMSFT shizhMSFT assigned binbin-li and unassigned shizhMSFT Jun 30, 2022
@dtzar dtzar added the epic new work which requires one or more features, tasks, or issues to complete. label Jun 30, 2022
@dtzar
Copy link
Contributor

dtzar commented Jul 21, 2022

Other than 2fa - it seems this work is complete and we can close this item out? @binbin-li @SteveLasker
IMO I don't think 2fa is important for now and should be tracked in a separate issue.

@SteveLasker
Copy link
Contributor Author

If someone has tried the experience, as opposed to reviewing PRs, I'm happy to close.
The 2fa was related to cloud provider specific login scenarios. For instance, you can use az acr login to set the docker credentials for registry operations.
I believe aws has a similar thing, but implemented through a docker plug-in.

I'm not suggesting notation login is vendor/cloud aware of specific 2fa, rather we work with vendor/cloud provider logins, through the docker cred store.

@yizha1 yizha1 moved this from In Progress to PR Review in Notary Project Planning Board Jul 25, 2022
@yizha1 yizha1 linked a pull request Jul 25, 2022 that will close this issue
9 tasks
@yizha1 yizha1 linked a pull request Jul 25, 2022 that will close this issue
Repository owner moved this from PR Review to Done in Notary Project Planning Board Jul 27, 2022
@dtzar dtzar modified the milestones: RC-1, alpha-3 Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request epic new work which requires one or more features, tasks, or issues to complete.
Projects
Status: Done
5 participants