Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update KU and EKU requirements #86

Merged
merged 1 commit into from
Oct 17, 2022
Merged

Conversation

priteshbandi
Copy link
Contributor

@priteshbandi priteshbandi commented Oct 5, 2022

Signed-off-by: Pritesh Bandi <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2022

Codecov Report

Merging #86 (0d65292) into main (b5df54c) will decrease coverage by 0.32%.
The diff coverage is 82.35%.

@@            Coverage Diff             @@
##             main      #86      +/-   ##
==========================================
- Coverage   79.34%   79.02%   -0.33%     
==========================================
  Files          28       28              
  Lines        2053     2064      +11     
==========================================
+ Hits         1629     1631       +2     
- Misses        324      332       +8     
- Partials      100      101       +1     
Impacted Files Coverage Δ
x509/cert_validations.go 84.11% <82.35%> (-4.57%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

x509/cert_validations.go Show resolved Hide resolved
x509/cert_validations.go Show resolved Hide resolved
Copy link

@patrickzheng200 patrickzheng200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@priteshbandi priteshbandi merged commit 56bd40a into notaryproject:main Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

id-kp-codeSigning EKU restriction for signing certificate.
4 participants