Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error responses from server so they get logged #766

Closed
endophage opened this issue Jun 3, 2016 · 1 comment
Closed

Fix error responses from server so they get logged #766

endophage opened this issue Jun 3, 2016 · 1 comment
Milestone

Comments

@endophage
Copy link
Contributor

We're logging the error from serving an error. We should always log the error that was served to ensure reporting systems get triggered.

Use an appropriate log level. Anything in the 5XX range should get logged as an error. 4XX should probably be info.

@cyli
Copy link
Contributor

cyli commented Jun 4, 2016

https://github.com/docker/notary/blob/master/server/timestamp/timestamp.go#L65 is getting logged as an error, and it should probably not be an error - this can happen if someone has metadata cached locally, and then tries to pull from a server that doesn't know about that metadata. For instance if they uploaded signed metadata to one notary server, and then switched notary servers and tried to pull.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants