Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

atomically updates #527

Closed
HuKeping opened this issue Jan 30, 2016 · 2 comments
Closed

atomically updates #527

HuKeping opened this issue Jan 30, 2016 · 2 comments

Comments

@HuKeping
Copy link
Contributor

In my opinion, the UpdateMany() should either update all the record or nothing. And it do use transaction in the database one:
https://github.com/docker/notary/blob/master/server/storage/database.go#L73-L75

But the memory one seems not:
https://github.com/docker/notary/blob/master/server/storage/memory.go#L63-L69

@endophage
Copy link
Contributor

MemoryStore is only used for testing so this is non-critical. However it would be ideal to have the stores all implement the interface in a consistent manner so definitely something to be corrected.

@riyazdf
Copy link
Contributor

riyazdf commented Aug 2, 2016

Resolved with #824

@riyazdf riyazdf closed this as completed Aug 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants