Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the repo team ownership according to the CODEOWNERS/MAINTAINERS files #4

Closed
toddysm opened this issue Mar 4, 2023 · 9 comments
Labels
Governance issues to improve governance posture

Comments

@toddysm
Copy link
Contributor

toddysm commented Mar 4, 2023

Currently there is no github team with permissions to maintain this repository. For the purpose of segregation of duties, I propose to have repo ownership team with members listed in the CODEOWNERS/MAINTAINERS files. The proposal is to create a GitHub team with the name notaryproject-governance-maintainers with members from the above files and assigning this team ownership of the .github repository.

@yizha1
Copy link
Contributor

yizha1 commented Mar 4, 2023

LGTM

@SteveLasker
Copy link
Contributor

I believe this is about:

  • org maintainers
  • sub-project maintainers

As the project evolved, additional repos have been added:

I'd suggest creating another issue to capture and clarify the relationship between:

  • Notary v1 notary
  • Notary v2 (aka notation) (collection of repos)
  • TUF incubation

And the additional repos that span the org:

  • Org Governance - currently split between notary and .github PRs
  • Website content, which spans the breadth of the project
  • Roadmap, also meant to cover the breadth of the org project.

@toddysm
Copy link
Contributor Author

toddysm commented Mar 10, 2023

I am confused. This particular issue (#4) is about the .github repository under the Notary Project organization. As a good security practice, we should have separate teams for each repository so we can manage repository access on a granular basis. My proposal is to match have the folks included in the https://github.com/notaryproject/.github/blob/main/CODEOWNERS file for the .github repository in a GH Team that owns the .github repository.

The CNCF TOC @mattfarina already created an issue for clarifying the relationship between name, sub-projects, and repos. I believe you are asking for the same. There is also issue #3 about the overall Org maintainers.

Regarding the governance split between notary and .github repository, it was agreed in the community that we will migrate all the governance to the .github repository. Though, right now we are struggling with having approvals on any PR in the .github repository because of the block on this particular ask (#4). So, can we move this one and progress faster?

To explain what the block is, none of the people actively working on the governance have CODEOWNERS rights on the .github repository because they are neither ORG maintainers or repo owners. I am asking to make them repo owners.

@priteshbandi
Copy link

LGTM

1 similar comment
@vaninrao10
Copy link

LGTM

@iamsamirzon
Copy link
Contributor

LGTM IANAM

@NiazFK
Copy link

NiazFK commented Mar 10, 2023

LGTM

@FeynmanZhou
Copy link
Member

LGTM to create a GitHub team for CODEOWNERS/MAINTAINERS.

@toddysm
Copy link
Contributor Author

toddysm commented Mar 13, 2023

Based on the above approvals from active maintainers this is completed to unblock PR approvals for this repository.

@toddysm toddysm closed this as completed Mar 13, 2023
@yizha1 yizha1 added the Governance issues to improve governance posture label Mar 20, 2023
@yizha1 yizha1 moved this from Todo to Done in Notary Project Planning Board Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Governance issues to improve governance posture
Projects
Status: Done
Development

No branches or pull requests

10 participants