Added the code for the Base and Dummy exchange classes to the exchang… #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Synced with master again.
No tests have been run on this yet so there will definitely be some minor bugs or syntax errors.
grimlis
approved these changes
May 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added the beginnings for the abstraction of the exchange and have incorporated them into the TradingEnv class. The only exchange that is implemented right now is the dummy exchange which is to be used for training and testing. Since I am missing the "data/agents/PPO2__MlpLnLstmPolicy__IncrementalProfit__1.pkl" pickle file at the moment I can't run it. I think it will run smoothly, however, definitely check that it does.