Better NoJs Support around ThemeToggle

[ohchase]

I am using this template but would like to provide a no javascript version of my site by default

When configuring the main config with an explicit theme I would have expected the themetoggle javascript resource wouldn't be included

[extra]
theme = "dark"

Relevant theme logic in the header.html template where themetoggle.js is linked:

apollo/templates/partials/header.html

Lines 136 to 165 in 577d9b0

	{% set theme = config.extra.theme | default(value="toggle") %}
	{% if theme == "dark" %}
	<link rel="stylesheet" type="text/css" href="{{ get_url(path='theme/dark.css') }}" />
	{% elif theme == "light" %}
	<link rel="stylesheet" type="text/css" href={{ get_url(path="theme/light.css") }} />
	{% elif theme == "auto" %}
	<link rel="stylesheet" type="text/css" href={{ get_url(path="theme/light.css") }} />
	<link rel="stylesheet" type="text/css" href="{{ get_url(path='theme/dark.css') }}" media="(prefers-color-scheme: dark)" />
	{% elif theme == "toggle" %}
	<link rel="stylesheet" type="text/css" href={{ get_url(path="theme/light.css") }} />
	<link id="darkModeStyle" rel="stylesheet" type="text/css" href="{{ get_url(path='theme/dark.css') }}" />
	{% endif %}
	<!-- Set the correct theme in the script -->
	<script src={{ get_url(path="js/themetoggle.js") }}></script>
	{% if theme == "dark" %}
	<script>setTheme("dark");</script>
	{% elif theme == "light" %}
	<script>setTheme("light");</script>
	{% elif theme == "auto" %}
	<script>
	if (window.matchMedia('(prefers-color-scheme: dark)').matches) {
	setTheme("dark");
	} else {
	setTheme("light");
	}
	</script>
	{% else %}
	<script>setTheme(getSavedTheme());</script>
	{% endif %}

When setting an explicit theme the only reason themetoggle.js is included is to set a local storage attribute

apollo/static/js/themetoggle.js

Lines 1 to 3 in 577d9b0

	function setTheme(mode) {
	localStorage.setItem("theme-storage", mode);
	}

I would like to figure out a way to make the template not use any javascript if you set a constant theme coloring.
Not sure if this is possible, but going to be working on trying to get this working in a fork.

One thought was setting the default to "light" and depending on the user's web browser client/viewer to auto dark mode site

[not-matthias]

When configuring the main config with an explicit theme I would have expected the themetoggle javascript resource wouldn't be included
Good catch!

I pushed an update that should fix this.

[ohchase]

@not-matthias @andresterba thank you very much! fantastic theme and greatly appreciate it having more options for NoJS support now!