Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(app): hide legacy import when empty and adjust default gpu setting #1197

Merged
merged 2 commits into from
Oct 18, 2019

Conversation

DalderupMaurice
Copy link
Member

@DalderupMaurice DalderupMaurice commented Oct 18, 2019

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate)

Types of changes

  • Chore (tests, refactors, and fixes)
  • New feature (adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING guidelines and confirm that my code follows the code style of this project.
  • Tests for the changes have been added (for bug fixes/features)

Documentation

  • Docs need to be added/updated (for bug fixes/features)

Closing issues

Fixes #

@codecov
Copy link

codecov bot commented Oct 18, 2019

Codecov Report

Merging #1197 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           develop   #1197   +/-   ##
=======================================
  Coverage     49.9%   49.9%           
=======================================
  Files          248     248           
  Lines         2120    2120           
  Branches       282     282           
=======================================
  Hits          1058    1058           
  Misses         884     884           
  Partials       178     178

@DalderupMaurice DalderupMaurice added the PR: good to merge Reviewed and approved label Oct 18, 2019
@DalderupMaurice DalderupMaurice merged commit d37f824 into develop Oct 18, 2019
@DalderupMaurice DalderupMaurice deleted the chore/fixes branch October 18, 2019 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: good to merge Reviewed and approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant