Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): fix deps, adjust renovate config #1174

Merged
merged 1 commit into from
Oct 1, 2019

Conversation

DalderupMaurice
Copy link
Member

@DalderupMaurice DalderupMaurice commented Oct 1, 2019

Description

Motivation and Context

Build was failing due to connected-react-router being updated, this can only be tested using integration tests. The build pipeline isn't able to capture these kind of issues

How Has This Been Tested?

Screenshots (if appropriate)

Types of changes

  • Chore (tests, refactors, and fixes)
  • New feature (adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING guidelines and confirm that my code follows the code style of this project.
  • Tests for the changes have been added (for bug fixes/features)

Documentation

  • Docs need to be added/updated (for bug fixes/features)

Closing issues

Fixes #

@codecov
Copy link

codecov bot commented Oct 1, 2019

Codecov Report

Merging #1174 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1174   +/-   ##
========================================
  Coverage    50.79%   50.79%           
========================================
  Files          240      240           
  Lines         2063     2063           
  Branches       276      276           
========================================
  Hits          1048     1048           
  Misses         843      843           
  Partials       172      172

@DalderupMaurice DalderupMaurice merged commit a6bede7 into develop Oct 1, 2019
@DalderupMaurice DalderupMaurice deleted the chore/build-fix branch October 1, 2019 16:57
@DalderupMaurice DalderupMaurice added the PR: good to merge Reviewed and approved label Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: good to merge Reviewed and approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant