Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adapt ansible plugin to nornir 3.0.0 #509

Closed
dbarrosop opened this issue Apr 9, 2020 · 4 comments
Closed

adapt ansible plugin to nornir 3.0.0 #509

dbarrosop opened this issue Apr 9, 2020 · 4 comments
Milestone

Comments

@dbarrosop
Copy link
Contributor

dbarrosop commented Apr 9, 2020

Relates to #486 and #504

Adapt plugin to nornir 3.0.0.

For reference look at https://github.com/nornir-automation/nornir_napalm.

Don't forget to add details to the plugin repository. You can do so by adding it here

If you have any questions don't hesitate to ask.

@dbarrosop dbarrosop added this to the 3.0.0 milestone Apr 9, 2020
@dbarrosop
Copy link
Contributor Author

@carlmontanari

@carlmontanari
Copy link
Contributor

First draft: https://github.com/carlmontanari/nornir_ansible

Not sure if we had planned to tweak how any of the inventory things work but a quick check through the 3.0.0 branch didn't look like it (v possible I missed something obvious though!). This is working with 2.4.0 and should work with 3.x+ I suspect. Just rolled w/ requirements.txt for now to get rolling quickly since I'm a poetry noob, but can convert over if y'all care. Other than no poetry, tried to copy the napalm plugin so it should at least be a close approximation to what we want!

Lemme know if there is anything wonky with it and I can get it tuned up!

@dbarrosop
Copy link
Contributor Author

Awesome! I will probably want to use for inventory plugins the same pattern I introduced to register connection plugins but that should require very small changes to what you already did. I will keep you posted.

@carlmontanari
Copy link
Contributor

Better draft ready here :)

Registration is working and such now. Pinned to 3.0.0.a2 for now. No docs still... one thing at a time I suppose :) but its working nicely w/ 3.0.0a2 in my testing so far!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants