Add Django 4.1-4.2 and Python 3.11 support #229
Conversation
* Increment version to 4.5.0
Andrew-Chen-Wang
changed the title
Pull Request Test Coverage Report for Build 5515266644
💛 - Coveralls |
|
Going to need to detect when we go into a transaction since Django added transaction BEGIN and COMMIT to the captured queries |
|
Came here to make a PR for it, found someone had done it already, amazing 😄🎉. |
|
@oriolclosa It is incomplete. Has a ton of errors due to the addition of BEGIN and COMMIT in sql query history. Would appreciate it if you could help make a PR! |
|
@Andrew-Chen-Wang When do you think this will be done? |
|
hi i haven't found the time to fix it up yet. For the most part it works on Django 4.2 but the test cases fail since it's validating output that Django users don't need to care about fwiw no code base changes are needed but haven't had time to fix tests |
|
@Andrew-Chen-Wang Thanks for the quick response! |
|
@Andrew-Chen-Wang When do you think this could be released? |
|
hey I think I just don't have the time to look over OSS for now @BertrandBordage I think another maintainer is needed if anyone else wants to make a branch to complete this pr, i'm happy to review it. Thanks:) |
|
Submitted PR #234 for this branch - it should resolve most if not all of the test failures. |
|
Well, that's embarrassing 😵💫 Overlooked a very simple error |
|
Are there any remaining components required to fully support 4.2? @jacklinke, are you actively working on this? If not, I am happy to assist in resolving any issues with the failing tests. |
|
It seems like the only things missing is correcting the number of queries expected when catching the amount. The issue is that Django 4.2 catches transactions and logs them (BEGIN, COMMIT, etc.). I think the most simplest solution is to just update the query count, but this can change anytime. Instead we need some regex to catch whenever transaction related terminology are being recorded and ignore it/exclude it from the counter since cachalot doesn't really care about that. |
…on-related queries (#238)
|
I was lurking around, but I figured I might as well ask 😅 : Is there anyone actively working on getting this into a reviewable state ATM? I am not too familiar with the internals of this project, but with a couple of pointers, I might be able to bring this one home. |
|
hi @denizs! Thanks for offering to help. If you'd like to help, create a PR pointing to the branch. The only tests are failing are PostgreSQL related. You can take a look at the tests themselves as I suspect they are the culprit. |
|
I completely forgot about those missing tests. I'll take a look at them, as soon as I have some time available. |
* Added a FilteredTransactionTestCase, updated tests. * Added more filtered tests * Removed Python <3.10 from the tox envlist for Django main. * Enhanced error message to include current database vendor of the connection for better easier troubleshooting. * Use python3.10 for GH workflows, fix postgres range issues in tests. * Check if psycopg3 is in use, if so, add psycopg3 types to CACHABLE_PARAM_TYPES. --------- Co-authored-by: Benedikt Willi <[email protected]>
|
thank you @jacklinke @Hopiu for your contributions! |
|
Thanks everyone for your work! When can we expect a new release featuring these changes? |
|
@Andrew-Chen-Wang , sorry to bother you, but I think you might help with realeasing new version? |
|
Thank you for all the reminders, and apologies for the delay. 2.6.0 is now published. Thank you again for all the contributions everyone to getting this through! |
Add Django 4.2 and Python 3.11 support
Drops Django 2.2 and 4.0
Fixes #228