Skip to content

Commit

Permalink
Replace gulp.js with npm scripts
Browse files Browse the repository at this point in the history
"gulp.js" (1) is meant to be used as streaming build tool for larger
projects with many tasks to combine them to a simple workflow. Nord Hyper
is a small project with only one build /development task where gulp.js is
more overhead / too heavy weight.

The "lint" task should be replaced with a simple npm script command to run "eslint".

References:

  (1) https://gulpjs.com

GH-27
  • Loading branch information
arcticicestudio committed Jan 7, 2018
1 parent 4b0771b commit 8d905f3
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 52 deletions.
5 changes: 1 addition & 4 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,9 @@ jobs:
- image: circleci/node:8.7
steps:
- checkout
- run:
name: install-global-gulp-cli
command: sudo npm install -g gulp-cli
- run:
name: npm-install
command: npm install
- run:
name: lint
command: gulp --harmony lint
command: npm run lint
4 changes: 1 addition & 3 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,5 @@ os:
before_install:
- rm -rf ./node_modules
before_script:
- npm install -g gulp-cli
- npm install gulp
- npm install
script: gulp --harmony lint
script: npm run lint
2 changes: 1 addition & 1 deletion docs/development/testing.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
Nord Hyper uses [ESLint][eslint] to analyse the source code. To show the current lint status run

```sh
gulp lint
npm run lint
```

[installation]: ../getting-started/installation.md
Expand Down
39 changes: 0 additions & 39 deletions gulpfile.js

This file was deleted.

8 changes: 3 additions & 5 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,14 +31,12 @@
"scripts": {
"docs:build": "npm run docs:clean && gitbook install ./docs && gitbook build ./docs ./build/docs",
"docs:clean": "node_modules/.bin/del ./build/docs",
"docs:dev": "npm run docs:build && gitbook serve ./docs ./build/docs"
"docs:dev": "npm run docs:build && gitbook serve ./docs ./build/docs",
"lint": "eslint --color index.js"
},
"devDependencies": {
"del-cli": "1.1.0",
"eslint": "4.15.0",
"gitbook-cli": "2.3.2",
"gulp": "3.9.1",
"gulp-eslint": "4.0.1",
"gulp-help": "1.6.1"
"gitbook-cli": "2.3.2"
}
}

0 comments on commit 8d905f3

Please sign in to comment.