-
Notifications
You must be signed in to change notification settings - Fork 467
Detect minor versions changes when copying www folder #66
Comments
Build number should be set to an Integer for plugin to work properly now. Does not need to be the same as what is displayed to customer (which our build server was currently doing). Guess that is OK, but needs better documentation. Still believe we need to re-sync www folder on both upgrades and downgrades though, to not get odd bugs when testing older builds. Created a PR to fix this: #67 |
We have talked with you a lot about that :) Still think that when you install older version of the app over the newer one - you should first delete the app from the device. But agree about the docs. Docs need more work, although there's already much info about build version. Regarding PR - didn't think that someone would need that, that's why it's just checking if build version has increased. But don't see any problem in setting it to inequality. |
Merged PR. |
@nikDemyankov I haven't investigated this, but won't this PR be a problem for the version numbering issue you talk about in the readme and that is discussed in #45? Because the Android versions will always be greater when build for separate architectures than the iOS version. |
@alexbuijs Haven't test it, but it shouldn't. That PR will reinstall |
Ok, thanks! |
Only checked this in iOS, not sure if this is the same on Android
Plugin only checks for major version changes when determining when to copy the www folder.
How to reproduce problem, lets assume that:
Plugin also only installs www folder if major revision is larger than previous install, not if it's lower, which sometimes causes problems when going back and forward between test builds.
Suggested fixes:
BOOL isApplicationUpdated = [NSBundle applicationBuildVersion] > _pluginInternalPrefs.appBuildVersion;
to
BOOL isApplicationUpdated = [NSBundle applicationBuildVersion] != _pluginInternalPrefs.appBuildVersion;
in HCPPlugin.m
Might submit a PR if I get more time to code this weekend. :)
The text was updated successfully, but these errors were encountered: