Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use [email protected] #210

Merged
merged 3 commits into from
Oct 3, 2023
Merged

fix: use [email protected] #210

merged 3 commits into from
Oct 3, 2023

Conversation

gnkz
Copy link
Contributor

@gnkz gnkz commented Oct 3, 2023

We were using a commit when installing forge-std as a dependency for vulcan. This is a problem because when you create a new forge project it comest with a tagged version installed that doesn't have all the cheatcodes that the commit could have. This means that if a user creates a new forge project and then installs vulcan on top the compilation will fail since the tagged version might not have the cheatcodes that we are using

To fix this:

  1. Use the latest forge-std tagged release
  2. Create interfaces to access new cheatcodes that are not yet released on that tag but that were included in foundry

@gnkz gnkz merged commit bda8bf0 into main Oct 3, 2023
@gnkz gnkz deleted the fix/use-forge-std-tag branch October 3, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant